[xdebug-general] Re: Use a flat array for line coverage. (take 2)

From: Derick Rethans <derick[@]xdebug.org>
Date: Thu, 16 Feb 2012 11:00:31 +0000 (GMT)

On Thu, 9 Feb 2012, Taavi Burns wrote:

> I revisited the line coverage data structure refactoring I did in the
> summer. It still looks like a fairly easy 4% win in overall
> performance when running PHPUnit's own test suite (with coverage).
> https://github.com/derickr/xdebug/pull/15
> Thanks for accepting my other patches! I didn't see any comments on
> this particular bit, so I have no idea if it just lay forgotten or if
> it's not stylistically correct or… Just wondering if there's anything
> else I can do to help get this (or something like it) merged in (or
> knowing that it's not interesting to the project as a whole).

Not forgotten, but you'd added a comment saying something along the
lines that you weren't sure whether it was a proper thing :-)
I've added some comments/questions to the pull request.


Like Xdebug? Consider a donation: http://xdebug.org/donate.php
Xdebug | http://xdebug.org | xdebug-general@lists.xdebug.org
twitter: @derickr and @xdebug
Received on Thu Feb 16 2012 - 11:00:32 GMT

This archive was generated by hypermail 2.2.0 : Mon Jun 25 2018 - 06:00:04 BST