[xdebug-dev] Bug 0000180: collected includes not shown in trace files

The following bug has been CLOSED
======================================================================
http://bugs.xdebug.org/bug_view_page.php?bug_id=0000180
======================================================================
Reporter: judas_iscariote
Handler:
======================================================================
Project: Xdebug
Bug ID: 180
Category: Usage problems
Reproducibility: always
Severity: major
Priority: normal
Status: closed
Operating System: Linux 64 bit
PHP Version: 5.1-dev
Xdebug Version: 2.0.0rc1-dev
======================================================================
Date Submitted: 2006-05-07 03:04 CEST
Last Modified: 2006-05-07 18:20 CEST
======================================================================
Summary: collected includes not shown in trace files
Description:
For some reason I can't figure , xdebug trace files, contained the value of
the included/required files and worked OK. but at some point between 5.1.2
and 5.1.4 development it stopped working and now it just mention
include/required but not what file was included.

i.e

in the past traces looked like :

require_once('/path/to/included/file') /srv/www/htdocs/foo.php:10

but now it just shows

require_once() /srv/www/htdocs/foo.php:10

======================================================================

----------------------------------------------------------------------
 judas_iscariote - 2006-05-07 03:30 CEST
----------------------------------------------------------------------
gotcha :)

here is the patch ;)

--- xdebug.c 14 Apr 2006 10:07:07 -0000 1.310
+++ xdebug.c 7 May 2006 01:29:36 -0000
@@ -979,7 +979,7 @@
                tmp->lineno = cur_opcode->lineno;

 #if (PHP_MAJOR_VERSION == 6) || \
- (PHP_MAJOR_VERSION == 5 && PHP_MINOR_VERSION == 1) || \
+ (PHP_MAJOR_VERSION == 5 && PHP_MINOR_VERSION >= 1) || \
        (PHP_MAJOR_VERSION == 5 && PHP_MINOR_VERSION == 0 &&
PHP_RELEASE_VERSION > 5) || \
        (PHP_MAJOR_VERSION == 4 && PHP_MINOR_VERSION == 4 &&
PHP_RELEASE_VERSION > 0)
                if (tmp->function.type == XFUNC_EVAL) {

----------------------------------------------------------------------
 judas_iscariote - 2006-05-07 03:35 CEST
----------------------------------------------------------------------
of course this is because in current PHP CVS version is 5.2.0-dev
so PHP_MINOR_VERSION is > 1 ;)

----------------------------------------------------------------------
 judas_iscariote - 2006-05-07 03:47 CEST
----------------------------------------------------------------------
ok.seems this is much better right ?

--- xdebug.c 14 Apr 2006 10:07:07 -0000 1.310
+++ xdebug.c 7 May 2006 01:45:57 -0000
@@ -979,7 +979,7 @@
                tmp->lineno = cur_opcode->lineno;

 #if (PHP_MAJOR_VERSION == 6) || \
- (PHP_MAJOR_VERSION == 5 && PHP_MINOR_VERSION == 1) || \
+ (PHP_MAJOR_VERSION == 5 && PHP_MINOR_VERSION >= 1) || \
        (PHP_MAJOR_VERSION == 5 && PHP_MINOR_VERSION == 0 &&
PHP_RELEASE_VERSION > 5) || \
        (PHP_MAJOR_VERSION == 4 && PHP_MINOR_VERSION == 4 &&
PHP_RELEASE_VERSION > 0)
                if (tmp->function.type == XFUNC_EVAL) {
@@ -2503,7 +2503,7 @@
 #endif
                        break;

-#if (PHP_MAJOR_VERSION == 5 && PHP_MINOR_VERSION == 1) ||
(PHP_MAJOR_VERSION >= 6)
+#if (PHP_MAJOR_VERSION == 5 && PHP_MINOR_VERSION >= 1) ||
(PHP_MAJOR_VERSION >= 6)
                case IS_CV:
                        return *zend_get_compiled_variable_value(zdata,
node->u.constant.value.lval);
                        break;

----------------------------------------------------------------------
 derick - 2006-05-07 18:20 CEST
----------------------------------------------------------------------
Fixed in CVS, thanks for the patch!

Bug History
Date Modified Username Field Change
======================================================================
2006-05-07 03:04judas_iscarioteNew Bug
2006-05-07 03:04judas_iscarioteBug Monitored: judas_iscariote
2006-05-07 03:30judas_iscarioteBugnote Added: 0000396
2006-05-07 03:35judas_iscarioteBugnote Added: 0000397
2006-05-07 03:47judas_iscarioteBugnote Added: 0000398
2006-05-07 18:20derick Bugnote Added: 0000399
2006-05-07 18:20derick Status new => closed
======================================================================
Received on Sun May 07 2006 - 18:20:08 BST