[xdebug-dev] Bug 0000137: feature_get for general commands

The following bug has been RESOLVED.
======================================================================
http://bugs.xdebug.org/bug_view_page.php?bug_id=0000137
======================================================================
Reporter: mccabe
Handler: derick
======================================================================
Project: Xdebug
Bug ID: 137
Category: Feature/Change request
Reproducibility: always
Severity: trivial
Priority: normal
Status: resolved
Operating System:
PHP Version: 4.3.10
Xdebug Version: 2.0-dev
Resolution: fixed
======================================================================
Date Submitted: 2005-07-31 16:15 CEST
Last Modified: 2006-01-24 22:32 CET
======================================================================
Summary: feature_get for general commands
Description:
If you query xdebug with "feature_get -n breakpoint_set" you will get a
reply:
<response command="feature_get" transaction_id="2"
feature_name="breakpoint_set" supported="1"></response>

Shouldn't the text data of the tag be set as well?

ie, the default case of DBGP_FUNC(feature_get) should be changed to:
                XDEBUG_STR_CASE_DEFAULT
                        xdebug_xml_add_text(*retval,
xdstrdup(lookup_cmd(CMD_OPTION('n')) ? "1" : "0"));
                        xdebug_xml_add_attribute(*retval, "supported",
lookup_cmd(CMD_OPTION('n')) ? "1" : "0");
                XDEBUG_STR_CASE_DEFAULT_END

?
                XDEBUG_STR_CASE_DEFAULT
                        xdebug_xml_add_attribute(*retval, "supported",
lookup_cmd(CMD_OPTION('n')) ? "1" : "0");
                XDEBUG_STR_CASE_DEFAULT_END

======================================================================

----------------------------------------------------------------------
 derick - 2006-01-24 22:32 CET
----------------------------------------------------------------------
Fixed in CVS - thanks for your report.

Bug History
Date Modified Username Field Change
======================================================================
2005-07-31 16:15mccabe New Bug
2005-07-31 16:15mccabe Bug Monitored: mccabe
2006-01-24 22:32derick Bugnote Added: 0000358
2006-01-24 22:32derick Assigned To => derick
2006-01-24 22:32derick Resolution open => fixed
2006-01-24 22:32derick Status new => resolved
======================================================================
Received on Tue Jan 24 2006 - 22:32:59 GMT